Move MovieWriterMJPEG class to jpg module it depends on#106013
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jun 5, 2025
Merged
Move MovieWriterMJPEG class to jpg module it depends on#106013akien-mga merged 1 commit intogodotengine:masterfrom
jpg module it depends on#106013akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
6b35f26 to
de31031
Compare
Member
I have a PR that aims to address this, but I ran into an issue: #95867
We can probably reuse the "no default scene has been configured" dialog's code for this. Edit: I have a WIP branch that aims to do this, but I get a crash when the dialog appears (I don't know why, the backtrace doesn't tell me much): https://github.com/Calinou/godot/tree/editor-moviewriter-ask-for-movie-file Edit 2: This was addressed by #106231, with the exception of the text alignment in the alert dialog. |
Mickeon
reviewed
May 3, 2025
de31031 to
0bec705
Compare
4 tasks
Calinou
approved these changes
Jun 4, 2025
AThousandShips
approved these changes
Jun 5, 2025
0bec705 to
78eb0b6
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MovieWriterMJPEGdoesn't work withmodule_jpg_enabled=no#90932.MovieWriterMJPEGwhen jpg module is disabled #100166.Draft as it includes Use libjpeg-turbo for improved jpg compatibility and speed #104347 to avoid conflicts, I'll rebase once it's merged.I don't intend to work on it further, but there are various UX issues I noticed which may be worth addressing (@Calinou):
.aviextension with the jpg module disabled, and likely already before when using any other extension than.avior.png, the movie writer doesn't give any warning and starts, but prints an error:It should probably validate that the file type is supported before running the project in movie writer mode, showing explanations to the user with a popup.
When no movie writer write path is configured, the following dialog is shown. It has multiple UX issues.

editor/movie_writer/movie_fileproject setting.res://).The expectation to select the output format (avi or png) just based on the file extension, with the only information available in the documentation for the project setting, is suboptimal. In the future, such features might be better served with a dedicated dialog (similar to the "Customize Run Instances..." dialog) that lets users configure all the settings for encoding.